Ganesh

Results 21 comments of Ganesh

Ah... after further review, I think I see what's happened. Somehow, the getter and the 'which_\' got conflated. (see https://github.com/thesayyn/protoc-gen-ts/issues/39#issuecomment-852207171) The current 'getter' is coded to be the 'which_\' Per...

I'm not familiar with your code-base; but if you point me to a likely file, I'll do the code/test/PR ... ... Ok, i looked into descripter.js & createOneofGetter()... I see...

Ok. I see what you're saying; It is mainly the **name** that is conflated. The other languages distinguish between msg.getValue() and msg.getValueType: [[java]](https://github.com/thesayyn/protoc-gen-ts/issues/96#issue-1034494055) msg.getValueCase() [[javascript]](https://developers.google.com/protocol-buffers/docs/reference/javascript-generated#oneof) msg.getValueCase() [[dart]](https://developers.google.com/protocol-buffers/docs/reference/dart-generated#oneof) msg.whichValue() [[python]](https://developers.google.com/protocol-buffers/docs/reference/python-generated#oneof) message.WhichOneof("value")...

Breath some life into this... A) it would be better if the [current] accessor for the 'field discriminator' was not using the field's 'name'. (so that one could use .name...

The generated .findOne() has the same problem. Is **says** it will return an Entity; but it is mapped to the DTO. This makes it painful for those of us trying...

Not clear to me what is the problem/solution... Should the methods return an entity? or a DTO? Is it just a doc/synchronization problem? If you confirm the cause/solution, then maybe...

Cost me a few hours wondering why MacOS Spotlight finds text in [compiled] .js files but not in [source] .ts files. And there's no way to tell Spotlight to override/disable...

I've tried various things; the simplest I have that mostly "works" is: Presumably using webpack via angular: % npm install yuki-createjs --save In my package.json: "dependencies": { ... "yuki-createjs": "0.0.3",...

For the record: after upgrading Angular and Typescript to latest versions (4.1.3, 2.3.3) using: import createjs from 'yuki-createjs'; seems to satisfy Typescript compiler. Still trying to get 'ng serve' to...

And now, webpack is happy! The solution was to add module.exports to index.js: ``` require('./lib/easeljs-0.8.2.combined.js'); require('./lib/preloadjs-0.6.2.combined.js'); require('./lib/soundjs-0.6.2.combined.js'); require('./lib/tweenjs-0.6.2.combined.js'); module.exports = window.createjs; ```