intl-tel-input icon indicating copy to clipboard operation
intl-tel-input copied to clipboard

Add build utils script

Open NamPNQ opened this issue 3 years ago • 1 comments

Add a script for build utils.js

NamPNQ avatar Oct 15 '20 14:10 NamPNQ

Thanks so much for submitting this - how exciting! I just need to find the time to understand and smoke test this properly, so please bear with me.

jackocnr avatar Oct 28 '20 10:10 jackocnr

@NamPNQ believe it or not, I am finally getting around to looking into this! I can only apologise for the ridiculous delay, but I hope you understand that open source work can suck up a lot of hours of your life for very little to no money, hence it being de-prioritised in recent years. Now I'm assuming you have likely moved on with your life 😂 but on the off chance you're still interested in this project, I'll share my thoughts: this would absolutely make a brilliant addition to the project, and I have gotten it building on my end, with lots of warnings but no errors! The only problem is that (A) when I build a new utils.js file, the file doesn't seem to work for me, despite it building without errors, and the contents of the file even looking similar to how they did before, unfortunately when I load it in the demo, I don't get any errors, but the placeholder number never appears which means it never initialises properly. And (B) the filesize of utils.js jumps up from 250kb to 330kb (that's with me disabling debug mode in grunt/closure-compiler.js). Do let me know your thoughts if you feel like resurrecting this dinosaur! But of course, I completely understand if this project no longer interests you.

jackocnr avatar Apr 06 '23 16:04 jackocnr

Hello @jackocnr, hope you're doing well

I just updated the build script and all test is passed :)

NamPNQ avatar Apr 20 '23 09:04 NamPNQ

Amazing, this is working perfectly, thank you so much @NamPNQ! The built utils.js works perfectly, tests pass as you say, and the build file is a similar size to before. Thanks again!

jackocnr avatar Apr 20 '23 21:04 jackocnr