colorbox icon indicating copy to clipboard operation
colorbox copied to clipboard
verified publisher icon jackmoore

Bugfix maxHeight after $.colorbox.resize()

Open lufton opened this issue 11 years ago • 4 comments

Earlier, if I set .colorbox{maxHeight:'95%'...} then colorbox frame gets vertical scrollbar (if content is heighter than frame) but if then I do $.colorbox.resize() my colorbox frame becomes heighter than wrapper page and my maxHeight option is ignored, so this is bugfix for it.

lufton avatar Aug 13 '14 08:08 lufton

Will you merge this?

I don't have merge rights on this repo.

How to implement correct resize after window resize in case of maxHeight is configured?

No idea.

aik099 avatar Aug 13 '14 10:08 aik099

+1 I've encountered this problem before. Thanks @lufton.

albell avatar Oct 29 '14 19:10 albell

+1 This fix worked for me, thank you.

websiteduck avatar Oct 22 '15 15:10 websiteduck

Just tested this, works fine. Thanks @lufton.

Needs merging, current code ignores maxHeight when resizing.

Tested in a site that makes heavy use of colorbox (multiple "nested" colorboxes by changing its content, image galleries, product quick views, etc...)

I'm not sure it should default to 100% max height though, because it could possibly affect current implementations. In my opinion it should maintain current behaviour when no maxHeight is set.

gonssal avatar Mar 30 '16 17:03 gonssal