USharpVideo-Subtitles icon indicating copy to clipboard operation
USharpVideo-Subtitles copied to clipboard

This file is not processed/cleaned up properly

Open owlboy opened this issue 2 years ago • 2 comments

problimatic-file.srt.zip

Formatting tags are not filtered out and newline \n markers do not work.

This is the first time I have run into this issue.

owlboy avatar Sep 24 '23 01:09 owlboy

Would you mind testing this SubtitleManager.cs if it works for you: https://github.com/jacklul/USharpVideo-Subtitles/blob/36943cc6aef7a0c7f9bd693032caaed21da1a1de/Assets/USharpVideoSubtitles/Scripts/SubtitleManager.cs

I've tested it in Unity and it seems to be working, I've also tried to give it a complex case like this one:

1
00:00:000--> 00:01:00,000
{\an3}<font color="yellow"><i>This is the police{\fscx125\fscy123\fn7th Service Condensed}!{\r}</i></font>
<b>Slow that vehicle down{\fscx125\fscy123\fn7th Service Condensed}!{\r}</b><

and it seemed to parse it correctly!

jacklul avatar Sep 25 '23 07:09 jacklul

I’ll try to give it a shot soon!

I appreciate you taking the time to look at this issue.

owlboy avatar Sep 25 '23 16:09 owlboy

Hey, were you able to test it out?

jacklul avatar May 05 '24 20:05 jacklul

Hello!

Sorry for the delay. I dropped this into my current up-to-date install of the 1.1.0 release, in a fully up-to-date project using Unity 2022 with VRCSDK v3.5. I tested with the original problem .srt. Everything seems to work as expected!

Thank you! I really appreciate this component. Sorry for failing to get back to you promptly.

owlboy avatar May 08 '24 23:05 owlboy

Also, if you would like to mention my theater on the readme, you can list "The Vantage - By OwlBoy". I've been running it since 2017. It's a private space, so it can't be linked. It's the one mentioned/shown in my "making a theater" page.

Reach out in-app if you would like to visit!

owlboy avatar May 09 '24 00:05 owlboy

Glad it all works. I keep only public worlds on the list, I don't think there is any advantage of mentioning a world that person reading can't visit easily.

jacklul avatar May 09 '24 20:05 jacklul