Jack Francis

Results 586 comments of Jack Francis

@mboersma are we sure this is working? the most test run for this PR was within the expected time duration range of previous runs (withough the `-race` option)

@dthorsen @brianlieberman I've gone ahead and moved this out of the 1.5 milestone as we plan to ship v1.5.0 next week. We look forward to this landing in the v1.6...

@CecileRobertMichon @willie-yao is this still an issue?

/test pull-cluster-api-provider-azure-e2e-optional

This lgtm, thanks @LochanRn! Can you update UT in `azure/scope/managedmachinepool_test.go`? You should be able to simply add to the `getAzureMachinePool` helper func like this: ``` $ git diff azure/scope/managedmachinepool_test.go diff...

/retitle Add subnetName to AzureManagedMachinePool

/release-note-edit ```release-note Add subnetName to AzureManagedMachinePool ```

Because this is adding a new property I'm going to remove the `kind/bug` classification so we don't cherry-pick this into previous releases. cc @CecileRobertMichon