Jack Fox

Results 55 comments of Jack Fox

I think this is an issue with the HashMap architecture, and probably has a similar issue with keys. The only fix I can think of would be altering the underlying...

I've added pending Expecto tests in https://github.com/fsprojects/FSharpx.Collections/blob/master/tests/FSharpx.Collections.Tests/PersistentHashMapTest.fs and https://github.com/fsprojects/FSharpx.Collections/blob/master/tests/FSharpx.Collections.Tests/TransientHashMapTest.fs

marking as a bug for now, as all main collections data structures should have tests

added some tests, but ran into bug #123

Resolved #123 and found new bug, #125

@gusty sorry for long silence. I think github forgot to notify me. This seems like a good feature. I'm happy to consider a PR. Tests appreciated.

Renaming to reflect this issue has turned into a performance issue. No idea if this is still current,. #110 should be used to shed light on this.

@rmunn this is a good idea, and since there are already unit tests in place, probably can be done safely (after reviewing unit tests for some comfort level of completion)....

I created RandomAccessList from @forki 's implementation of PersistentVector. I have a new found interest in RandomAccessList. I have found it is the ideal implementation of Vector in a project...

@rmunn are you still interested in submitting a PR to Collections.Experimental? I'm hoping to get a 2.0 release out in the next few weeks.