resyntax icon indicating copy to clipboard operation
resyntax copied to clipboard

Published 20 hours ago • verified publisher icon jackfirth

The analyze mode should not care about comments

Open sorawee opened this issue 1 year ago • 1 comments

Users of the analyze mode are already applying the changes manually, so it's fine to strip comments away. This is especially good if doing so allows Resyntax to discover more issues.

sorawee avatar Dec 25 '23 05:12 sorawee

Interesting. All things being equal, I'd rather make Resyntax better at preserving comments automatically than give an option to show fixes that strip them, but I could see this being useful. Though it would also be handy to know which fixes in that linked pull request are fixes that Resyntax wasn't able to preserve comments for - it's possible I could fix that problem directly for some cases.

jackfirth avatar Jan 08 '24 12:01 jackfirth

I've greatly improved Resyntax's ability to preserve comments automatically (see #247 and #243). There's still some gaps, but I believe most situations are fixable now. I've also added debug logging, which records when a suggestion is discarded due to dropped comments. Given all that, I will close this for now, as it should be unnecessary.

jackfirth avatar Aug 29 '24 07:08 jackfirth