acts_as_commentable icon indicating copy to clipboard operation
acts_as_commentable copied to clipboard

Published 20 hours ago • verified publisher icon jackdempsey

Specify Rails version in Gemspec

Open mattconnolly opened this issue 11 years ago • 3 comments

Specifying which version of rails (e.g. "~> 3.2.0" for 3.0.1 and "~> 4.0.0" in 4.0.1) in the gem spec file would allow bundler to resolve which version of acts_as_commentable is appropriate for an application to use.

mattconnolly avatar Feb 13 '14 03:02 mattconnolly

acts_as_tree does this: https://github.com/amerine/acts_as_tree/blob/master/acts_as_tree.gemspec

mattconnolly avatar Feb 13 '14 04:02 mattconnolly

Thanks for the thoughts Matt. I'm happy to consider a patch. I don't have much time for OSS these days unfortunately.

jackdempsey avatar Feb 13 '14 04:02 jackdempsey

I'll send through a patch shortly. I'd like to offer a patch for the 3.0.1 version as well for the benefit of our rails 3.2 apps.

Can you please create a 3.x branch from the latest 3.0.1 gem release so I can make a pull request onto that?

mattconnolly avatar Feb 13 '14 10:02 mattconnolly