Jack Christensen comments

Results 489 comments of


                                            Jack Christensen

Easy CRUD Operations Support

Was this PR intended for the main pgx repo? Everything is in an `internal` path so it wouldn't be usable.

pgtype: enable deep copy of pgtype.Map

See https://github.com/jackc/pgx/pull/2048 for some discussion of copying type maps.

Ability to drain underlying chunkReader

I think https://pkg.go.dev/github.com/jackc/pgx/v5/pgconn#PgConn.Hijack is what you want.

Multidimensional array flattened when using CopyFrom instead of Exec+Insert

I have determined what the problem is, but a full solution is eluding me. Here's what is happening. pgx's `CopyFrom` always uses the binary format. However, you are passing it...

Multidimensional array flattened when using CopyFrom instead of Exec+Insert

I'll leave it open for now. It *is* a bug. Even if one I'm not sure can be fixed.

Query or QueryRows does not return ErrNoRows error when no record is found

First, `Query` will never return `ErrNoRows`. A query returning no rows is a perfectly valid result. Only `QueryRow` has the expectation of a non-empty result. Second, the fact that your...

Query or QueryRows does not return ErrNoRows error when no record is found

@silentstranger5 Not sure what's going on from that little snippet -- but you should test errors with https://pkg.go.dev/errors#Is.

Query or QueryRows does not return ErrNoRows error when no record is found

`QueryRow` and `CollectOneRow` are designed for when exactly one row is expected and it is an error if it is not found. Typically, this is find a single row by...

Use a struct for named args

That's definitely doable. In your example, `pgx.StructArgs(m)` would return a `pgx.QueryRewriter` that reflected over the struct fields.

Use a struct for named args

The function could return a `pgx.NamedArgs`.