jack2 icon indicating copy to clipboard operation
jack2 copied to clipboard

jackdbus: Stop recurrent wakeups when no save is pending

Open StefanBruens opened this issue 2 years ago • 2 comments

Most processing happens as a result of an incoming DBus event. The only case when a timed processing is needed is due to an pending save.

Instead of implementing a full event loop just run the timed loop while a save is pending, and use an infinite timeout otherwise.

Fixes: #962

StefanBruens avatar Dec 13 '23 05:12 StefanBruens

The PR changes seem fine, but if one is using jack the idea of saving battery is non-sensical. JACK will keep the audio device active at all times on a very quick / small buffer size, this will save very little

falkTX avatar Dec 13 '23 09:12 falkTX

The PR changes seem fine, but if one is using jack the idea of saving battery is non-sensical. JACK will keep the audio device active at all times on a very quick / small buffer size, this will save very little

Running jackdbus does not equal running jack. People will have jackdbus running in the background continously, even if they use jack just sometimes.

StefanBruens avatar Dec 13 '23 16:12 StefanBruens