jack2 icon indicating copy to clipboard operation
jack2 copied to clipboard
verified publisher icon jackaudio

Adit control api backports

Open amiartus opened this issue 2 years ago • 4 comments

Hello,

please consider accepting following linux specific back-ports developed by ADIT audio team. The patches allow proper responsiveness to some failure states on linux and fix the hang ups that would occur otherwise.

Best Regards, Adam Miartus

amiartus avatar Jul 24 '23 19:07 amiartus

These look good to me. Thank you! The added signal setup should really be moved to jackctl_setup_signals() in a followup commit (these ones are cherry picks and it is good to keep them like this instead of rewriting git history). For jackdbus at least, it would be good to have epoll() call on the side of the control API user/caller (jackd, jackdbus). Extending the Control API with notion of either libevent (should work on Windows too), or similar abstraction, will achieve this goal.

nedko avatar Jul 25 '23 17:07 nedko

I added jackctl_finish_signals() to the API: https://github.com/LADI/jack2/commit/ae7b5d0dda4205adeccab85e6b1ca99aab2300fc

It is a function to call for cleaning, after waiting on a signal set, to undo the jackctl_setup_signals() and restore to previous state.

nedko avatar Jul 25 '23 20:07 nedko

thank you for reviewing and refactoring. looks better to me as it is now after your changes.

amiartus avatar Jul 26 '23 06:07 amiartus

thanks @imaami I can have a look at this over the holidays

amiartus avatar Dec 21 '23 20:12 amiartus