jack2 icon indicating copy to clipboard operation
jack2 copied to clipboard

Remove unused JackArgParser::GetArgv

Open Teemperor opened this issue 3 years ago • 1 comments

This is not called anywhere. Also this function doesn't do anything useful besides leaking memory in its current form. I think the idea was to give this a char *** (instead of char **) paramter that will be filled and then can be used by the caller. But in its current form it just allocates a pointer with the address being only used in the local variable (which then goes out of scope and the memory is lost).

Teemperor avatar Apr 01 '22 13:04 Teemperor

Note: The removed line fill_n ( argv[i], fArgv[i].length() + 1, 0 ); is also a buffer overflow.

Teemperor avatar Apr 01 '22 13:04 Teemperor