qa_datasets_converter icon indicating copy to clipboard operation
qa_datasets_converter copied to clipboard

Dependencies and __init__.py

Open geblanco opened this issue 5 years ago • 0 comments

Hello @jackalhan,

Thanks for the effort put in this repository, nice job!

I think nltk should be present in the requirements.txt , it is required by triviaqa.py

Traceback (most recent call last):
  File "executor.py", line 7, in <module>
    from ds_formatter import qangaroo, mctest, insuranceqa, triviaqa, wikiqa, narrativeqa, msmarco, ubuntudialogue, cnnnews, squad, quasar
  File "...datasets/qa_datasets_converter/ds_formatter/triviaqa.py", line 3, in <module>
    import nltk
ImportError: No module named nltk

Also, in order to make the executor work I needed to add a __init__.py inside the ds_formatter folder (e.g.: touch ds_formatter/__init__.py). This was the error before.

Traceback (most recent call last):
  File "executor.py", line 7, in <module>
    from ds_formatter import qangaroo, mctest, insuranceqa, triviaqa, wikiqa, narrativeqa, msmarco, ubuntudialogue, cnnnews, squad, quasar
ImportError: No module named ds_formatter

In summary, I did:

  • Add an __index__.py to ds_formatter folder to fix local dependencies
  • Add nltk to requirements.txt

I can pull request it if you prefer. :)

Best, Guillermo

geblanco avatar May 24 '19 14:05 geblanco