Jack Berg

Results 759 comments of Jack Berg

@mateuszrzeszutek addressing that has been on my todo list! It minimally needs to be reflected in the `ComponentRegistry`'s key definition of what constitutes a distinct instrumentation scope, which currently uses...

Sorry, but its not clear what you're asking for. `TlsUtil` is an internal class - we won't make enhancements to it without a particular use case in mind. Maybe you're...

This makes sense to me 👍 . Extending BOMs (or platforms) is a use case that is described in the [gradle docs](https://docs.gradle.org/current/userguide/java_platform_plugin.html#sec:java_platform_bom_import), so seems reasonable for us to do.

Serialization of jaeger and zipkin scope attributes is blocked on spec issue [#2744](https://github.com/open-telemetry/opentelemetry-specification/issues/2744).

@jkwatson please take a look when you have a chance

Here's the benchmarks before this change: ``` Benchmark (aggregation) (valueGen) Mode Cnt Score Error Units HistogramBenchmark.aggregate_10Threads EXPLICIT_DEFAULT_BUCKET FIXED_BUCKET_BOUNDARIES avgt 10 30941.755 ± 824.071 ns/op HistogramBenchmark.aggregate_10Threads:·gc.alloc.rate EXPLICIT_DEFAULT_BUCKET FIXED_BUCKET_BOUNDARIES avgt 10 0.003...

1.17.0 uses the semantic conventions from version 1.12.0 of the specification, which [did not include](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.12.0/semantic_conventions/trace/general.yaml#L2) `net.sock.peer.addr`. `net.sock.peer.addr` [does exist](https://github.com/open-telemetry/opentelemetry-specification/blob/main/semantic_conventions/trace/general.yaml#L49-L53) in the yet to be released 1.13.0 of the spec. Once...

Looks good - Sorry about the delay @carlosalberto!

> The advantage of "Categorized Log" is that we use the same term in the attribute name "log.category", whereas it is unclear what attribute name to use for "Schematic" or...