Jack Berg

Results 759 comments of Jack Berg

I don't think circular dependencies are a problem for BOMs. If they are, gradle lets you publish them just fine. Here's a [commit](https://github.com/open-telemetry/opentelemetry-java/commit/5457db01a2259d765ff8d6e18cb887d2e9fa67bc) which adds a dependency from `opentelemetry-bom` to...

These properties are around to stay, even if there's an alternative recommended approach. I'm reluctant to expand the surface area, but don't consider promotion to stable an expansion.

Sure - I've assigned you. Quick note: we'll want to retain support for `otel.experimental.resource.disabled.keys` for at least 1 minor release cycle, but warn if we see it. Pseudocode is something...

Its true that the java implementation does percent encoding and percent decoding of baggage metadata entries such that the round trip encode / decode is lossless: ``` @Test void roundTrip()...

> So I think this issue here can be fixed without waiting for anything from W3C side. Fixing here only for the W3C to change would expose our users to...

The SpanData, MetricData, LogRecordData interfaces are only meant to be in-memory representations of those data types. They are intentionally opinionated about serialization, which is a task normally reserved for SpanExporter,...

> I am getting memory leaks at application shutdown (one is a io.netty.util.internal.InternalThreadLocalMap that is tracked in Netty). The other appears below. Yes I think this is indeed a (small)...

After a decent amount of work I was able to reproduce this. ThreadLocals are released when threads stop, and so as long as all the threads that use CodedOutputStream are...

> But! if you forget to shutdown the top level constructs (ExecutorService, ThreadPools) AND the spawned threads DID use threadlocal storage, then you're hit with a bigger problem: every web...