gitman icon indicating copy to clipboard operation
gitman copied to clipboard

Loop through all nested configs

Open jacebrowning opened this issue 1 year ago • 3 comments

@DavidWatkins can you remind me the purpose of the function I removed in this pull request? As far as I can tell the alpha release from this branch is behaving as I expect in relation to nested configs but main is not.

jacebrowning avatar May 20 '24 22:05 jacebrowning

@jacebrowning This was removing any configs that come in from any pulled dependencies but still allowed subdirectories to be included for aggregating configs. I would not remove it. What is the behavioral difference you are observing?

DavidWatkins avatar May 21 '24 03:05 DavidWatkins

@DavidWatkins I opened https://github.com/jacebrowning/gitman/issues/337 to show how to reproduce the behavioral difference.

jacebrowning avatar May 21 '24 19:05 jacebrowning

@jacebrowning Ah I see. It's been a year and I cannot remember exactly why I wanted recursion over directories without automatically cloning those sub-dependency gitman.yml files, but with fresh eyes, it makes more sense to allow for this behavior. Go ahead and push this change and we'll make changes on our end to support the new workflow if it breaks anything.

DavidWatkins avatar May 22 '24 02:05 DavidWatkins

@DavidWatkins thanks for taking a look! I'll release this as 3.5.2 and please open an issue if you notice any strange behavior.

jacebrowning avatar May 22 '24 11:05 jacebrowning

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.07%. Comparing base (16cfe3c) to head (d1c1917). Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   91.36%   91.07%   -0.30%     
==========================================
  Files          15       15              
  Lines        1193     1176      -17     
  Branches      243      238       -5     
==========================================
- Hits         1090     1071      -19     
- Misses         70       71       +1     
- Partials       33       34       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 12:08 codecov[bot]