gitman icon indicating copy to clipboard operation
gitman copied to clipboard

Add optional parameters fed to git fetch

Open asteele0 opened this issue 3 years ago • 4 comments

I had a scenario where I needed to also specify custom arguments to the git fetch command, in addition to git clone. This wasn't supported, so I've added it as just another YAML option.

Pretty much just copied the implementation of user_params in most places.

Tests run and all but 3 succeed, which is how many failed when I ran them before these changes.

asteele0 avatar Nov 09 '22 18:11 asteele0

What additional fetch params did you need in your scenario? I wonder if there's a commonality with clone.

jacebrowning avatar Nov 09 '22 19:11 jacebrowning

What additional fetch params did you need in your scenario? I wonder if there's a commonality with clone.

I needed --depth 1 specifically, but I could also see people wanting --prune, or --verbose too.

asteele0 avatar Nov 09 '22 20:11 asteele0

I needed --depth 1 specifically

Then perhaps this feature can start by sharing params configuration option and passing it to both clone and fetch, which have many of the same options.

I could also see people wanting --prune, or --verbose

I think I would rather see those as command-line options passed to gitman rather than stored in the configuration file. gitman -v2 could make git more verbose, for example.

jacebrowning avatar Nov 09 '22 21:11 jacebrowning

Then perhaps this feature can start by sharing params configuration option and passing it to both clone and fetch, which have many of the same options.

While they do share some parameters, there are many that they also don't share.
I did a diff on the options from the manual (it's not perfect, but it's close enough): https://www.diffchecker.com/iGgPsZWj

I think I would rather see those as command-line options passed to gitman rather than stored in the configuration file. gitman -v2 could make git more verbose, for example.

That makes sense to me. Could pass that down to everything applicable, which might make debugging easier.

asteele0 avatar Nov 09 '22 21:11 asteele0