James Booth comments

Results 70 comments of


                                            James Booth

.as_pointcloud() on PointCloud subclasses

This is an easy add and would be great, will try and add sometime soon!

Print an informative message for Procrustes when failing to converge.

@grigorisg9gr thanks greg! Hmm when you said it failed to converge, what was the failure case? I'm wondering if instead this should be a case where an error is raised,...

Print an informative message for Procrustes when failing to converge.

@grigorisg9gr yeah I think that's what @patricksnape means, and I agree, that's the best design.

Add tem importer

@patricksnape any reason to hold off on getting this in now?

WIP: BREAKING move towards immutable PCAModel

@patricksnape proposal - implement a setting for `n_active_components` so users won't stumble into weird bugs trying to set this

Some objects are Copyable that maybe shouldn't be

I can check this over when I split up the packages

Add cca math method

@patricksnape maybe a quick test though?

port download_file in from menpocli

@patricksnape no, https://github.com/menpo/menpofit/issues/97 includes it's own copy of this code. Think we are better to revisit integrating this into Menpo for 0.8 once we have seen how the menpofit pretained...