PokemonGoBot icon indicating copy to clipboard operation
PokemonGoBot copied to clipboard

Pokemon listed in "evolve_before_transfer" does not evolve

Open casper-gh opened this issue 8 years ago • 33 comments

Description: Pokemon listed in "evolve_before_transfer" does not evolve, instead it keeps all those pokemon causing POKEMON_INVENTORY_FULL

Steps to reproduce:

  1. Add pokemon to evolve_before_transfer
  2. Run the bot
  3. All pokemon listed in evolve_before_transfer are kept causing POKEMON_INVENTORY_FULL

Expected behavior: Pokemon should be evolved and then transferred

Actual behavior: Pokemon does not evolve

Version: 0.6.0

Operating System: Ubuntu

Java version: Latest

Leave this sentence in your issue as proof that you have read and used this template.

My config: http://pastebin.com/GC8Ggh7u

casper-gh avatar Aug 21 '16 19:08 casper-gh

It willl wait for evolve_stack_limit=10 before start evolving

FrancYescO avatar Aug 21 '16 19:08 FrancYescO

@FrancYescO I don't really understand what it means, but I have like 30+ Pidgeys and bot still doesn't evolve

casper-gh avatar Aug 21 '16 19:08 casper-gh

Sometime it will log "Pokémon ready for stack evolve xx" probably you need more candys?

FrancYescO avatar Aug 21 '16 19:08 FrancYescO

I got Pokémon ready for stack evolve 0, but I have 5K + of Pidgey candies

casper-gh avatar Aug 21 '16 19:08 casper-gh

Pidgy is also here..

obligatory_transfer=DODUO,RATTATA,CATERPIE,PIDGEY

FrancYescO avatar Aug 21 '16 20:08 FrancYescO

but doesn't evolve_before_transfer will evolve the pokemon first? So what you're saying is I cannot define the same pokemon in both obligatory_transfer and evolve_before_transfer ?

casper-gh avatar Aug 21 '16 20:08 casper-gh

How can a Pokémon be evolved if you "obligatory" throw away?

FrancYescO avatar Aug 21 '16 20:08 FrancYescO

The thing is, the bot neither throws those pokemon away nor evolve it, all those pokemon are retained making my pokemon inventory full

casper-gh avatar Aug 21 '16 20:08 casper-gh

Post your Pokémon list

FrancYescO avatar Aug 21 '16 20:08 FrancYescO

Sorry I manually evolved them all, will try to get the list when pokemon are full again

casper-gh avatar Aug 21 '16 20:08 casper-gh

Ok I got the pokemon list here http://pastebin.com/87Y8RrcJ

You can see there's a lot of Pidgeys...

casper-gh avatar Aug 22 '16 06:08 casper-gh

and still Pokémon ready for stack evolve 0 ???? if you don't see this incrementing and reaching 10 (as you config require) you will never get an evolve.

FrancYescO avatar Aug 22 '16 07:08 FrancYescO

that's why it's a bug?

casper-gh avatar Aug 22 '16 08:08 casper-gh

yeah but to me is working good, so wee need to find what's wrong with your config.

FrancYescO avatar Aug 22 '16 08:08 FrancYescO

can you share your config?

casper-gh avatar Aug 22 '16 08:08 casper-gh

"obligatoryTransfer" : [ ], "evolveBeforeTransfer" : [ "CATERPIE", "RATTATA", "WEEDLE", "PIDGEY", "ZUBAT" ], "evolveStackLimit" : 70, "useLuckyEgg" : 1,

butw probably somehow related to https://github.com/jabbink/PokemonGoBot/issues/1088

FrancYescO avatar Aug 22 '16 08:08 FrancYescO

So don't put anything in obligatory transfer?

casper-gh avatar Aug 22 '16 09:08 casper-gh

no, i don't want to obligatory transfer.

FrancYescO avatar Aug 22 '16 09:08 FrancYescO

also make sure to edit the json file if present and not proprieties one.

FrancYescO avatar Aug 22 '16 09:08 FrancYescO

can you share the entire json template?

casper-gh avatar Aug 22 '16 09:08 casper-gh

i'm using develop with some pr merged so some config will be in conflict.

what can affect this issue is already up

FrancYescO avatar Aug 22 '16 09:08 FrancYescO

Having the same issue. Config info related to this: obligatory_transfer=CATERPIE,RATTATA,WEEDLE,PIDGEY (this seems to be ignored because none of these are transferred, they are all still in my inventory) evolve_before_transfer=CATERPIE,RATTATA,WEEDLE,PIDGEY evolve_stack_limit=30 use_lucky_egg=1 I currently have 14 Weedle, 15 Rattata, 23 Pidgey and 9 Caterpie. When I start the bot with the above settings nothing happens, they aren't transferred, they aren't evolved. I have 582 Weedle candy so I can evolve 48. I have 942 Rattata candy so I can evolve 37. I have 1256 Pidgey candy so I can evolve 104. I have 297 Catepie candy so I can evolve 24. I have 5 lucky eggs. I even cleared the obligatory_transfer line and still nothing happens.

MacDogg avatar Aug 22 '16 16:08 MacDogg

in my case, the config on obligatory_transfer works fine, just evolve_before_transfer isn't working

casper-gh avatar Aug 22 '16 16:08 casper-gh

the crucial thing is

"evolveStackLimit" : 70,

no evolve are done until we have enought pokemon to evolve defined by this value

obligatory_transfer pokemon are kept if also in the evolve_before_transfer (still a nosense to have in both list)

FrancYescO avatar Aug 22 '16 16:08 FrancYescO

My new config looks like this:

obligatory_transfer=DODUO evolve_before_transfer=CATERPIE,RATTATA,WEEDLE,PIDGEY,DROWZEE

But after 8 hrs botting, still getting full pokemon inventory because all the above pokemon are kept.

casper-gh avatar Aug 22 '16 16:08 casper-gh

if in your log you see

Stack of pokemon ready to evolve: 0

this is the issue but this can also mean you have not enought candy.. probably i need a full session log to understand something, also waiting for the next version might have solved this issue due to some changes done in the evolve func.

FrancYescO avatar Aug 22 '16 17:08 FrancYescO

I had the same issue with Drowzee, like 1k+ candies and fill up the inventory. I've also tried to put it in the obligatory transfer and also in the list of "evolve before transfer" but I got into another issue where I got an arithmetic exception (division by zero). I believe there is some problem with the candies evaluation. I am using 0.6 by the way.

th3n3rd avatar Aug 22 '16 18:08 th3n3rd

Yes, that's what I have

casper-gh avatar Aug 22 '16 18:08 casper-gh

One thing that helps, just tried, is to use the max_pokemon_amount parameter. If you set the latter to 1 the bot will discard all the duplicate leaving only one pokemon per type but for the ones listed within evolve_before_transfer list! (unless you need candies of course).

th3n3rd avatar Aug 22 '16 19:08 th3n3rd

Can you get the most recent develop version (and not 0.6.0 release) and test it again? Several pieces of code for the evolving got improved.

Sieberkev avatar Aug 24 '16 21:08 Sieberkev