PokemonGoBot icon indicating copy to clipboard operation
PokemonGoBot copied to clipboard

Feature: Thresholds

Open meekzyr opened this issue 8 years ago • 8 comments

This pull request adds thresholds for a maximum amount of looted Pokestops and caught Pokemon. This will prevent the bot from continuously catching Pokemon and looting Pokestops, which normally leads to your account being flagged.

Changes made:

  • Added a threshold for caught Pokemon and looted Pokestops
  • Delay the tasks for 12 hours before resetting the threshold.

meekzyr avatar Aug 16 '16 05:08 meekzyr

Ready for peer review.

meekzyr avatar Aug 16 '16 05:08 meekzyr

Hmm it is somehow similar to my changes https://github.com/jabbink/PokemonGoBot/pull/1095 However my changes simply stop the bot completely (instead stopping the single task) Probably yours is better thought through

alexbulyha avatar Aug 16 '16 05:08 alexbulyha

I believe yours is better, in any case i think 1000 is too much for Pokémon as i heard thats the value in ca 24h you get Banned for. Ah and do you know how i can "rewind" the last commits from my pull request here in github?

alexbulyha avatar Aug 16 '16 05:08 alexbulyha

Ah and one more thing, could you also make the waittime which is 12h choosable from settings please?

alexbulyha avatar Aug 16 '16 05:08 alexbulyha

@AlexBoulyga My apologies, I haven't checked pull requests recently. I had thought of how it would be beneficial to continue to walk around and hatch eggs, but maybe stopping entirely would be more human-like which could lead to less flagging.

meekzyr avatar Aug 16 '16 05:08 meekzyr

@AlexBoulyga I don't know how to rewind commits, unfortunately. However, I will go ahead and change the values and add a setting for the delay time in the morning.

meekzyr avatar Aug 16 '16 05:08 meekzyr

not sure here is the best place to do this, I'm new to GitHub, sorry for my noobishness

Would it complicate things a lot to change it so that it keeps the values for Pokemons caught so far and Pokestops visited so far somewhere locally, so even if let's say the bot crashes or is stopped, if restarted it will continue from the previous values.

HoreaM avatar Aug 16 '16 09:08 HoreaM

@HoreaM I believe this has recently added in #1129

meekzyr avatar Aug 17 '16 16:08 meekzyr