Joshua Bronson comments

Results 197 comments of


                                            Joshua Bronson

Harmonize E301 check with format in --preview mode?

I think ideally the solution here wouldn't be sensitive to how many lines were in the function definition. E.g. This should still be accepted code style: ```python @t.overload def foo(x:...

Compatible with Firefox as of version 57?

According to https://caniuse.com/#feat=textencoder Safari added support for TextDecoder in version 10.1. Another browser that streaming-dot can now declare compatible? 😊

Unable to find interpreter for pip hub

If the following is wrong: `python = use_extension("@rules_python//extensions:python.bzl", "python")` ...then are the https://rules-python.readthedocs.io/en/stable/toolchains.html#root-modules docs wrong too? Those docs are also missing the initial `python/` component before `extensions:python.bzl`. I followed those...

Code Coverage support in Buck2

@ndmitchell @stepancheg et al., has there been any renewed interest in this internally since the last time you checked, by any chance? (Context: I'm responsible for setting modern SDLC standards...

support using a variable (or expression) for conditional skipping, not just a dependency

Right, [sphinx.ext.doctest](https://www.sphinx-doc.org/en/master/usage/extensions/doctest.html) is not the same as the standard library's [doctest](https://docs.python.org/3/library/doctest.html) module. It's the former that provides `skip-if`, not the latter. Wonderful to hear there's interest in adding support for...

,

@gedw99 opened #10 to track your BTW, in case you want to follow

demonstrate usage inside a form

Just to give a little more background, here is [iron-form's validate function](https://github.com/PolymerElements/iron-form/blob/49758ac54ae6354966c7d0af1444d125beca8c13/iron-form.html#L237-L261): ``` js validate: function() { var valid = true; // Validate all the custom elements. var validatable; for...