Jaap Roes
Jaap Roes
Force pushed some isort fixes (forgot to run it on the last commit). The test failure (test-postgres (3.10 Django main)) is unrelated to this PR.
xls support is definitly dropped. It's a legacy format, the last version of Excel that used xls (instead of xlsx) was Excel 2003. I see no reason to support it,...
I've rebased, I won't be able to look into re-adding .tsv support so if that's a blocker it'll have to wait until I get back
The only use-case I've seen "in the wild" is in a Django project. All model classes have specific `DoesNotExist` and `MultipleObjectsReturned` error classes. And the `User` model is configurable, which...
I get what you are saying, I was just going by other use of `logger.error` in this file, e.g. `acquire_lock` also logs "temporary" failures at the error level: https://github.com/pinax/django-mailer/blob/ae0475c580a2217508b5aae2c71394c1936cdf5e/src/mailer/engine.py#L149-L167 I...
Well, having the locking error logged at the error level just saved us from even more debugging. It turns out that the reload for the config change didn't clear the...
As a workaround for the current behavior I resorted to a logging config with a special filter. It's slightly more complex than I would like, but it works: ``` import...
My issue with this middleware approach (and I have had a similar issue with django-cors-headers) is that it applies to all urls that are handled by Django. I.e. with this...
Well CORS (cross-origin resource sharing) is about removing security barriers that are in place by default, so I'm hesitant in saying that this is an improvement. IMHO an overly permissive...
To me the suggested mixin approach (which could probably also be turned into a decorator) seems to be the most pragmatic. It allows DOT to selectivly apply CORS to the...