react-dfp icon indicating copy to clipboard operation
react-dfp copied to clipboard

Conflicting docs on sizeMapping

Open hayleybech opened this issue 2 years ago • 0 comments

We had trouble getting the sizeMapping to work when following your sizeMapping, until we clicked the links to read Google's own documentation. That's when we realised it seems to work by specifying minimum viewport sizes not maximum sizes.

Your docs and examples on this page https://react-dfp.surge.sh/adslot/sizemapping/ show viewports working as maximum widths, however Google's docs and examples here https://developers.google.com/publisher-tag/guides/ad-sizes#responsive_ads show them working as minimum widths, and after testing, that does seem to be the case.

hayleybech avatar May 23 '22 05:05 hayleybech