react-dfp icon indicating copy to clipboard operation
react-dfp copied to clipboard

Should the SlotsProvider set PAGE level targeting?

Open patrick-mcdougle opened this issue 5 years ago • 0 comments

I was browsing through the codebase and I noticed the only way to set page level targeting (on the pubads service directly) is to use the function on the manager. IMO the slots provider would be a good place to set PAGE level targeting and the slot to be a good place to set SLOT targeting? What would you think of this change? Since we're doing manual merging in the slot today, I don't think this would be a bc break, it would just use the appropriate functions of the GPT library (and reduce the amount of merging you have to do manually)

patrick-mcdougle avatar Sep 10 '20 22:09 patrick-mcdougle