painter2 icon indicating copy to clipboard operation
painter2 copied to clipboard

Nothing painted just on tap

Open fellow7000 opened this issue 6 years ago • 10 comments

Hi! Nice plugin, thanks a lot!

The only issue I faced: once you just tap on the canvas, nothing is painted, no dot. Only if you swipe for a short, then you get something.

Would it be possible to update the plugin in order to get "dots" just on tap? Would be really useful.

Thanks in advance!

fellow7000 avatar Jul 14 '19 21:07 fellow7000

By the way, I slightly modified the source code and got what I wanted - now the dot with R of 1 pixel will be drawn if user just taped the screen without moving his finger for a while.

fellow7000 avatar Jul 15 '19 18:07 fellow7000

Hello and sorry for the late reply. Sure we can add that functionality to the lib! If you already have it implemented, could you please send a pull request?

ja2375 avatar Jul 15 '19 19:07 ja2375

I will try - I've never done this before :) I also implemented "erase" function but it's a bit dirty - it erases complete path which is met on the way of the "eraser" - a square form.

Probably you can have a look on code and make it better :)

fellow7000 avatar Jul 19 '19 18:07 fellow7000

So, looks like, pull request is generated. Have a look :)

fellow7000 avatar Jul 19 '19 19:07 fellow7000

Thank you! Will take a deep look at it when I have some time :)

ja2375 avatar Jul 19 '19 19:07 ja2375

Any news? :) I've just upgraded the lib a bit further to export Map of paths/paint in order to be able to re-load them into canvas for re-use.

fellow7000 avatar Aug 03 '19 14:08 fellow7000

Hey! Sorry, i have had no time to look at this because of work. But i will take a look at it now as i'm on holiday :) Wow, cool! Would you mind posting another PR with that functionality? That is something i wanted to implement here but i didn't have any time for it :(

ja2375 avatar Aug 04 '19 15:08 ja2375

Thanks for feedback! I think, I still need a bit of time to make it fully functionable. Hope to post in couple of weeks

fellow7000 avatar Aug 04 '19 20:08 fellow7000

Take your time. No need to hurry :)

ja2375 avatar Aug 04 '19 21:08 ja2375

By the way, I slightly modified the source code and got what I wanted - now the dot with R of 1 pixel will be drawn if user just taped the screen without moving his finger for a while.

hi, do you know how I can achieve this? https://github.com/ja2375/painter2/issues/5

aldwnesx avatar Mar 04 '20 04:03 aldwnesx