jmonkeyengine icon indicating copy to clipboard operation
jmonkeyengine copied to clipboard

com.jme3.anim.tween.action.BlendSpace: basic javadoc

Open pavly-gerges opened this issue 1 year ago • 7 comments

This PR adds a basic javadoc for the BlendSpace class.

pavly-gerges avatar May 27 '23 17:05 pavly-gerges

Javadoc is important, and I appreciate the considerable effort that's gone into this PR. Unfortunately, it's still very confusing. @Scrappers-glitch are you willing to continue refining it?

stephengold avatar Jul 24 '23 16:07 stephengold

@stephengold For me, this PR is complete, you can point to the confusing and/or missing parts, please don't forget to mention why these parts are confusing and a superior format for describing these confusing parts.

pavly-gerges avatar Jul 24 '23 17:07 pavly-gerges

@stephengold In this PR, I chose to stick to describing the behavior of the pattern used, or maybe the interaction of the API components, if you want to understand more, please use this paradigm designed by Remy (Most of this documentation is based on this paradigm, the talks on forums and my own techdemos): Monkanim: new animation system in the works

EDIT: Here are some examples of implementing new BlendSpaces in a user application: CustomBlendAction and CustomBlendSpaces

pavly-gerges avatar Jul 26 '23 09:07 pavly-gerges

Okay I am willing to refine this. @stephengold Do you recommend specific refinements to make it more simple. Maybe code samples? or more mathematical terms? any ideas so far?

pavly-gerges avatar Jan 22 '24 18:01 pavly-gerges

Figuring out why the javadoc is confusing and writing a clear explanation seems like a lot of effort. I don't want to spend more time on this PR.

stephengold avatar Jan 23 '24 18:01 stephengold

BlendSpace is all about a provider interface. It provides the blend weight value to blend between 2 actions. Blend weight is then used as the value of interpolation. That simple. I like to think of it from a higher perspective as an interface that enables the user to adjust the behavior of blending (a controller interface from an architectural perspective), and that blend weight value is a read-only value. It could be manipulated using the mediator BlendSpace#setValue(...).

pavly-gerges avatar Jan 24 '24 04:01 pavly-gerges

For me, this PR has completed. Please let me know if there are any changes you want to add, otherwise it's ready for merging.

pavly-gerges avatar Feb 01 '24 22:02 pavly-gerges