jmonkeyengine
jmonkeyengine copied to clipboard
AreaUtils: Migrated package to `com.jme3.util`
This PR includes:
- Migrating the
AreaUtils
class fromcom.jme3.scene.control
tocom.jme3.util
. - Deprecating
com.jme3.scene.control.AreaUtils
. - Jme3 copyright update.
EDIT: Targeting this issue #1825
To avoid code duplication, could you refactor the old deprecated class to keep only the public method and make it call the one in the new class?
To avoid code duplication, could you refactor the old deprecated class to keep only the public method and make it call the one in the new class?
Hello, yeah i will consider that.
Done, @riccardobl you could review it now.
EDIT:
- This PR should close this issue #1825.
I think the new class should not call the deprecated class, it should be vice-versa. I think this is also what @riccardobl meant.
I think the new class should not call the deprecated class, it should be vice-versa. I think this is also what @riccardobl meant.
Oh, i must have misunderstood this, okay i am going to refactor this.
EDIT: There is a small question though, should i move the private methods from the deprecated class to the new one ? I think they should be moved, so in case if we want to modify them later....
There is a small question though, should i move the private methods from the deprecated class to the new one ?
Yes.
Here we go, you can review this now.
Looks good to me, thanks