jmonkeyengine icon indicating copy to clipboard operation
jmonkeyengine copied to clipboard

AreaUtils: Migrated package to `com.jme3.util`

Open pavly-gerges opened this issue 2 years ago • 2 comments

This PR includes:

  • Migrating the AreaUtils class from com.jme3.scene.control to com.jme3.util.
  • Deprecating com.jme3.scene.control.AreaUtils.
  • Jme3 copyright update.

EDIT: Targeting this issue #1825

pavly-gerges avatar May 29 '22 22:05 pavly-gerges

To avoid code duplication, could you refactor the old deprecated class to keep only the public method and make it call the one in the new class?

riccardobl avatar Oct 08 '22 08:10 riccardobl

To avoid code duplication, could you refactor the old deprecated class to keep only the public method and make it call the one in the new class?

Hello, yeah i will consider that.

pavly-gerges avatar Oct 10 '22 10:10 pavly-gerges

Done, @riccardobl you could review it now.

EDIT:

  • This PR should close this issue #1825.

pavly-gerges avatar Dec 15 '22 20:12 pavly-gerges

I think the new class should not call the deprecated class, it should be vice-versa. I think this is also what @riccardobl meant.

Ali-RS avatar Dec 31 '22 06:12 Ali-RS

I think the new class should not call the deprecated class, it should be vice-versa. I think this is also what @riccardobl meant.

Oh, i must have misunderstood this, okay i am going to refactor this.

EDIT: There is a small question though, should i move the private methods from the deprecated class to the new one ? I think they should be moved, so in case if we want to modify them later....

pavly-gerges avatar Dec 31 '22 17:12 pavly-gerges

There is a small question though, should i move the private methods from the deprecated class to the new one ?

Yes.

Ali-RS avatar Dec 31 '22 17:12 Ali-RS

Here we go, you can review this now.

pavly-gerges avatar Dec 31 '22 17:12 pavly-gerges

Looks good to me, thanks

Ali-RS avatar Dec 31 '22 18:12 Ali-RS