jmonkeyengine icon indicating copy to clipboard operation
jmonkeyengine copied to clipboard

Published 20 hours ago • verified publisher icon jMonkeyEngine

JmeSurfaceView: Follow package naming conventions

Open pavly-gerges opened this issue 2 years ago • 4 comments

I have looked up the android core packages, i found the major package android.view where android views live and android.app where android application components live, but special featured android views are located within special packages like android.webkit.WebView and android.opengl.GlSurfaceView, so i think the best packaging option out there for JmeSurfaceView is com.jme3.view.surfaceview.JmeSurfaceView and i will create a package-info for it, if you are okay with these changes or have an objection let me know.

com.jme3.view can hold other android views as features for jme.

Due to issue #1800 , i accustomed to put JmeSurfaceView directly inside com.jme3.app which is wrong ! com.jme3.app is the package for jMonkeyEngine application components including app launchers and vital states.

pavly-gerges avatar Apr 23 '22 10:04 pavly-gerges

This is more like a Documentation issue from my opinion.

pavly-gerges avatar Apr 23 '22 11:04 pavly-gerges

This is more like a Documentation issue from my opinion.

I disagree because the fix is a breaking change.

stephengold avatar Apr 23 '22 17:04 stephengold

so i think the best packaging option out there for JmeSurfaceView is com.jme3.view.surfaceview.JmeSurfaceView and i will create a package-info for it, if you are okay with these changes or have an objection let me know.

I will try to take a response from the community.

pavly-gerges avatar Apr 23 '22 22:04 pavly-gerges

Here we go : https://hub.jmonkeyengine.org/t/relocate-jmesurfaceview-to-com-jme3-view-surfaceview-package/45510

pavly-gerges avatar Apr 23 '22 22:04 pavly-gerges

This issue was to be linked to PR #1819, i will close it as completed.

pavly-gerges avatar Dec 10 '22 10:12 pavly-gerges