idiorm icon indicating copy to clipboard operation
idiorm copied to clipboard

Published 20 hours ago • verified publisher icon j4mie

Fix for php 8.1+

Open DarkVss opened this issue 2 years ago • 4 comments

fix by issue

DarkVss avatar Apr 03 '23 11:04 DarkVss

This PR needs tests and in addition CI needs to be set up to run against the correct target versions of PHP for testing.

treffynnon avatar Nov 16 '23 11:11 treffynnon

This PR needs tests and in addition CI needs to be set up to run against the correct target versions of PHP for testing.

Yeah if there isn't anything Testing this line ok, but maybe we should add phpstan deprecation on pipelines.

Because as far as I understand it isn't fixing any issue, just a deprecation message.

https://github.com/phpstan/phpstan-deprecation-rules

eerison avatar Mar 26 '24 07:03 eerison

The test suite needs to be updated to target the version of php that this PR is attempting to fix. It also needs tests for the logic to change parameterisation of the query.

Also, the switch to booleans with the values TRUE and FALSE seems like something that would break MS SQL support so that would need to be tested too.

treffynnon avatar Mar 26 '24 08:03 treffynnon

The test suite needs to be updated to target the version of php that this PR is attempting to fix. It also needs tests for the logic to change parameterisation of the query.

Also, the switch to booleans with the values TRUE and FALSE seems like something that would break MS SQL support so that would need to be tested too.

Btw, thank you for reply and your effort to maintain this repo.

eerison avatar Mar 26 '24 09:03 eerison