James Holderness

@chaosemer Just to followup on the comments above, Windows Terminal now identifies support for copying to the clipboard with the parameter value `52` in its primary device attributes report. This...

I've just been testing this branch, and there appears to be an issue with the height calculation (I think only when you have the tab bar visible). Because when I...

I'm only interested in implementing the standard ones, like `DECPCTERM` and `DECEKBD`. Also, I think the XTerm protocol is closely related to #8719 (possibly intended to be the same thing,...

> I'd rather we opted for Kitty's instead as the most robust one existing and upon which the terminal working group was discussing as a base If you read the...

In case I'm not the only one that wasn't aware of this, it's worth noting that the current kitty keyboard protocol which everyone is implementing is not the same as...

I can't claim to fully understand this code, but my first impression is that this line looks wrong: https://github.com/microsoft/terminal/blob/1f71568c2a60fa7ec3549e72bc1c8c47c7033b29/src/host/getset.cpp#L1062 If we're applying an offset to the target origin, then shouldn't...

I've just tried now, and at least my test case can be fixed by subtracting the offset from the dimensions, i.e. changing the line quoted above to: ```cpp const auto...

FYI, I've done a bit more testing with rectangles that are partially off screen, and there are definitely more issues than the ones I've described above. That offset change by...

In case it helps, I've included my extended test case below. It's intended to be run in an 80x24 window and performs a series of moves in 8 different directions,...

> Of course, it is possible to determine this width by displaying the characters and checking how much the cursor has moved (sample in python is below), but this approach...