Jeremy Kun
Jeremy Kun
@asraa this is ready for a final review.
Hmmm. I think this will also break the CMake build because we don't yet have the ortools dependency in cmake, right?
Can't use it as a binary because we're depending directly on the C++ API. I'll try FetchContent.
> > Can't use it as a binary because we're depending directly on the C++ API. I'll try FetchContent. > > Yep, they even have a nice example of how...
> I admit I'm glossed over a little bit at the solver's implementation, I'll keep digging in it though. @asraa I think it's fair to not devote too much time...
Squashing the PR.
Due to the internal deprecation of the MPSolver API, I migrated the solver API to math_opt and squashed the changes from https://github.com/google/heir/pull/1033 into this PR (since https://github.com/google/heir/pull/1033 contained simplifications of...
The build failure doesn't occur on my machine, looks like an outdated cstdlib on the GH action runner: ``` external/com_google_ortools/ortools/util/fp_roundtrip_conv.cc:66:7: error: call to 'to_chars' is ambiguous std::to_chars(buffer.data(), buffer.data() + buffer.size(),...
@ivanradanov I'd like to fix this issue along with #388. Is the project actively soliciting contributions? Is there bandwidth to review my fixes? It's not clear to me who is...
Going to run cibuildwheel locally to test this before merging it, on top of Alex's changes to the python deps