ormlite-android icon indicating copy to clipboard operation
ormlite-android copied to clipboard
verified publisher icon j256

Fixed UpdateBuilder.update() / DeleteBuilder.delete() always return 0 when WAL enabled

Open TYZRPVX opened this issue 2 years ago • 2 comments

Fixed UpdateBuilder.update() / DeleteBuilder.delete() always return 0 when WAL enabled

  1. The root cause is the same as referred in https://github.com/j256/ormlite-android/pull/131
  2. Maybe reflection is necessary, execSQL returns void, but executeSql returns correct value
  3. Calling methods in a compatible way has been verified and correctness is guaranteed, if executeSql failed, call execSQL

Thanks for reviewing this PR

TYZRPVX avatar Mar 02 '23 09:03 TYZRPVX

Thanks for this. Submitted a couple of things for consideration.

j256 avatar Mar 07 '23 19:03 j256

@j256 May you review again, thanks for the efforts

TYZRPVX avatar Mar 10 '23 02:03 TYZRPVX