ormlite-android icon indicating copy to clipboard operation
ormlite-android copied to clipboard

Published 20 hours ago • verified publisher icon j256

Replaced Android support-v4 library with AndroidX loader library

Open leandroruiz96 opened this issue 3 years ago • 17 comments

Replaced deprecated Android support-v4 library with AndroidX loader library

  • Now builds .aar
  • Added .aar plugins for maven
  • Needs Android SDK (just set $ANDROID_HOME environment variable)

leandroruiz96 avatar Oct 13 '21 14:10 leandroruiz96

Leaving this on draft because this will need to setup the Android SDK on the CCI pipeline.

leandroruiz96 avatar Oct 13 '21 14:10 leandroruiz96

We need this fix too!

fernan88 avatar Oct 20 '21 15:10 fernan88

What does this do to the backwards compatibility? @kpgalligan any comments?

j256 avatar Oct 20 '21 18:10 j256

Should I release 2 versions? One with the old android-support and one with AndroidX?

j256 avatar Oct 25 '21 19:10 j256

That would be helpful for the people who still haven't migrated to AndroidX. But considering that the original Android support library is no longer maintained, I wouldn't keep the support version for much longer.

leandroruiz96 avatar Oct 25 '21 19:10 leandroruiz96

Hi @j256, do you have any update on this?

fernan88 avatar Nov 03 '21 15:11 fernan88

Hi @j256! every conflict has been resolved for this pull request. Could you take a look at this update for a future merging? Thanks in advance!

nogueirasjorge avatar Feb 11 '22 20:02 nogueirasjorge

Hey @leandroruiz96 , can you merge up from trunk. I see a lot of duplicate changes were are confusing the diff.

j256 avatar Feb 11 '22 22:02 j256

Hey @j256, I've merged up the changes again. So, you will be able to see just the changes related to this merge request.

nogueirasjorge avatar Feb 16 '22 19:02 nogueirasjorge

How can I test these changes? I'm not up on my Android testing. I'd like to verify that the old version of the generated files work as well as the new.

j256 avatar Feb 17 '22 21:02 j256

To test this, you will need to package the library and import the ormlite-android.aar generated into an android project. The easiest way to do this is by placing the aar into a libs folder inside the main module in your Android project:

Screen Shot 2022-02-21 at 15 58 21

and adding it in the build.gradle as a dependency:

dependencies { implementation files('./libs/ormlite-android.aar') }

nogueirasjorge avatar Feb 21 '22 19:02 nogueirasjorge

Hi @j256, just to check. Could you test the changes? It'll be really nice to have this merged in a future release.

nogueirasjorge avatar Mar 08 '22 12:03 nogueirasjorge

Hi, this would help us a lot as well 👍

bio007 avatar Jun 13 '22 13:06 bio007

Hi @j256, I hope you are doing well. Have you had the chance to review this branch? It'd be very helpful to have it merged.

nogueirasjorge avatar Aug 04 '22 12:08 nogueirasjorge