Keep empty img tags

Open Strubbl opened this issue 1 year ago • 3 comments

keep empty img tags to avoid missing images, e.g. https://github.com/wallabag/wallabag/issues/7700

Sep 27 '24 22:09 Strubbl

coverage: 94.897%. remained the same when pulling cb190fcf3e00bc52c83b194f92837a577af379e3 on Strubbl:patch-1 into 1281bf3d7045d2f2682d1af6ba3715e492184e9a on j0k3r:master.

Sep 27 '24 23:09 coveralls

Thanks for the contribution.

Would you be able to include a test like the following?

https://github.com/j0k3r/graby/blob/1281bf3d7045d2f2682d1af6ba3715e492184e9a/tests/GrabyTest.php#L1000-L1008

Aside, I find it weird that https://github.com/j0k3r/graby/pull/141 was made against Graby rather than Readability in the first place but whatever 🤷‍♀️

Sep 27 '24 23:09 jtojnar

Sorry, i am not sure how to write and run a proper test here.

Oct 10 '24 21:10 Strubbl