BusTrackDC-old icon indicating copy to clipboard operation
BusTrackDC-old copied to clipboard

iPhone 6/6 Plus support

Open adamcleavey opened this issue 9 years ago • 10 comments

All this requires is rebuilding with newer cordova-ios. I did so in a branch but cannot push a branch and create a PR for your review.

http://stackoverflow.com/questions/26283372/phonegap-and-iphone-6-plus-splash-screen-issue

adamcleavey avatar Nov 10 '15 21:11 adamcleavey

Hm...this doesn't work for you? It works fine on my 6. Just about to put up a new version for iOS9, but I don't have splash issues, do you?

j-ro avatar Nov 10 '15 21:11 j-ro

App Store, on iPhone 6 Plus After Rebuild, iPhone 6 Plus Sim

adamcleavey avatar Nov 10 '15 22:11 adamcleavey

first picture is app store version on my device, second picture is running in iPhone 6 plus simulator after following the instructions in that stack overflow response

adamcleavey avatar Nov 10 '15 22:11 adamcleavey

ah, you need an api key from WMATA, see readme on this repo. it's in config.js

j-ro avatar Nov 10 '15 22:11 j-ro

or, rather, you put your api key in config.js, but you'll need one

j-ro avatar Nov 10 '15 22:11 j-ro

i know that would resolve the alert, but I'm referring to optimizing the app for bigger sized devices. take a look at the status bar to see size difference, etc

adamcleavey avatar Nov 10 '15 22:11 adamcleavey

ah, gotcha -- this is intentional on my part, at least for now, but certainly a good improvement. No real need to update cordova to do it I don't think though, it's all html/javascript/css, so some new styles/media queries will probably do you nicely.

j-ro avatar Nov 10 '15 22:11 j-ro

the app actually handles itself fine: elements are laid out by percentage spacing, so they expand nicely, and the UI doesn't have any hanging elements that need to be laid out differently. The problem is that until the app has the right config options set, the device will render it in a blown-up, pixelated state in order to render it as-is, as it assumes the app hasn't been prepped for the bigger device. Once those config options are set (which 3.9.2 of cordova-ios does) everything works as expected and no css changes are required.

adamcleavey avatar Nov 10 '15 22:11 adamcleavey

Hm...interesting. I don't see this on my actual device, which is odd. The simulator does it pixel accurate, so it's double size, but on devices it renders correctly I think.

Anyway, if you want to update cordova, cool. That's kind of a headache sometimes, due to dependencies and plugins (mapkit is custom, so you can't update that, for example). But grab the latest (I just pushed a new version) and do a PR?

j-ro avatar Nov 10 '15 22:11 j-ro

and, I think you should be able to fork then PR, or fork, then branch, then merge to your forked master, then PR, right?

j-ro avatar Nov 10 '15 23:11 j-ro