arping icon indicating copy to clipboard operation
arping copied to clipboard

remove the risk of file descriptor reuse from arping

Open JacobTanenbaum opened this issue 1 year ago • 1 comments

using sock.deinitialize() outside of the goroutine that is using the socket leaves the potential for erroneous and unexpected behavior. When calling Ping() very quickly the socket fd can be reused while a goroutine is still trying to read from it and cause the goroutine to deadlock.

removing the sock.deinitialize() from the timeout select case as it will be taken care of by the goroutine upon its return

JacobTanenbaum avatar Feb 01 '24 16:02 JacobTanenbaum

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

openshift-merge-robot avatar Feb 17 '24 09:02 openshift-merge-robot