Jonas I. Liechti
Jonas I. Liechti
So would the goal be to reduce file size and storage space, like you do when storing only diffs?: https://github.com/alexbovet/flow_stability/blob/434caf46c06f57d41ea983ea3708f7c5d1508894/src/flowstab/temporal_network.py#L491 If this is already what you want then we can...
> I've already implemented some "smart" saving in save_inter_Ts for example.But, I need this think a bit more about how we should do that in the best way... Let me...
@alexbovet should we go for that or keep the current naming scheme?
https://github.com/alexbovet/flow_stability/pull/35#issuecomment-2306467560 We might want to add the possibility to install `flowstab` in "large" data mode where we consistently use `long long` for all index arrays.
In C++ we could simply use template functions which would allow us not having to specify the type of `indices` and `indptr`. I'm unsure if/how this can be done in...
_Not really an issue as with #44 we are going to remove the non-cython implementations, however:_ --- https://github.com/alexbovet/flow_stability/blob/8648a8bd715e3b086ed13cb7453d41754c176398/src/flowstab/SparseStochMat.py#L1866 uses non-existing attribute `_S` in the _non-cython_ case: https://github.com/alexbovet/flow_stability/blob/8648a8bd715e3b086ed13cb7453d41754c176398/src/flowstab/SparseStochMat.py#L1898-L1901 same is true...
See also https://github.com/alexbovet/flow_stability/pull/35#issuecomment-2355520641
Regarding the tests, there is now a little helper function that allows to compare matrices with not necessarily sorted indices: https://github.com/alexbovet/flow_stability/blob/b658f27a67921b5f69d192ebbe8c058c8cfea73d/tests/conftest.py#L75-L88 --- @alexbovet Regarding the `csr_` operations, would it make...
> > @alexbovet > > Regarding the `csr_` operations, would it make sense to perform an in-place [sort_indices()](https://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.csr_matrix.sort_indices.html#scipy.sparse.csr_matrix.sort_indices) before returning the `csr_matrix`? > > Is it necessary? Unsure. It could...
@alexbovet OK in our implementations it can matter!: If we take the example data from the comment: ```python import numpy as np from scipy.sparse import csr_matrix from flowstab.SparseStochMat import csr_csrT_matmul...