SmaCC icon indicating copy to clipboard operation
SmaCC copied to clipboard

SmaCC_Python #filename method is not a right name

Open jecisc opened this issue 5 months ago • 0 comments

In the nodes we have the method SmaCCParseNode>>#filename but in my case I have a PyFileNode and this method dois not return the file name but a FileReference from the origin file. This name seems weird to me.

The file reference is what I need so it's good for me. But I think the name of the method is not good and it makes the code more complex. Personally I added an extension on PyRootNode like this to make my code better:

PyRootNode>>#fileReference
	^ self filename

I'm just reporting this if it can be interesting to improve this in SmaCC directly

jecisc avatar Sep 11 '24 13:09 jecisc