mpc issues

16 levels mode + polyphony results in faulty durations

1

@Merwijn I was wrong in one of our communications. A single pad can effectively be played polyphonically. This happens when you're in 16 levels mode and you press multiple pads....

izzyreal

[real mpc2000xl] Can step recorder record MIDI notes for a MIDI track?

Verify on a real MPC2000XL whether the step recorder records MIDI input when the track is a MIDI track.

izzyreal

investigation

[real mpc2000xl] Can step recorder record MIDI notes for a DRUM track when note is unassigned?

1

If a note is not associated with any pads, is there still a note recorded? We know that the step editor can handle for example `37/OFF`, so the answer is...

izzyreal

investigation

[real mpc2000xl] Verify upon which input events MIDI monitor lights up

izzyreal

investigation

Note repeat doesn't work in ORIGINAL MIDI control mode

izzyreal

Note repeat doesn't work in SAMPLER/MIXER screens

izzyreal

Store pressed pads in a set

In several places we check which hardware pads are pressed, for example `RepeatPad`: ``` for (auto& p : hardware->getPads()) { if (!p->isPressed()) continue; ... ``` Instead, let's store the pressed...

izzyreal

code cleanup

performance improvement

When MIDI control mode is VMPC, MIDI track notes should be recorded like in ORIGINAL mode

We're currently calling `midiFullControl->processMidiInputEvent` in `mpc::audiomidi::MpcMidiInput` irrespective of whether the destination track is a DRUM or MIDI track. When it's a MIDI track, VMPC control mode makes no sense. So...

izzyreal