intellij-rainbow-brackets icon indicating copy to clipboard operation
intellij-rainbow-brackets copied to clipboard

JSX fragment tag short syntax does not work in light theme

Open ben-woodward-appsbroker opened this issue 2 years ago • 15 comments

Please support us before creating a feature request, thanks for your support 😁

Please check

  • [ ] I already support this project.
  • [x] If you are submitting a feature request, please do consider buy this plugin here or donating us on Open Collective Or by AliPay/WeChatPay.
  • [x] This issue/feature request is not reported before.

Your programming languages

Expected Behavior

When fragment tags are used <> and </> I would like them to be highlighted the same as other HTML tags

Current Behavior

They remain grey

ben-woodward-appsbroker avatar Dec 06 '22 09:12 ben-woodward-appsbroker

Hey @ben-woodward-appsbroker :wave:,

Thank you for opening an issue/feature request. We will get back to you as soon as we can.

Please consider support us by buying a license here or donating from OpenCollective https://opencollective.com/intellij-rainbow-brackets.

And we have a special plan for paid users, if you are a paid user, your issue or feature request will have a higher priority.

If you are creating a issue, please make sure you already read the latest change log here.

image It actually works, I don't understand what exactly you requested.

izhangzhihao avatar Dec 07 '22 01:12 izhangzhihao

Fragment tags have a short syntax which contains nothing between the chevrons.

https://reactjs.org/docs/fragments.html#short-syntax

On Wed, 7 Dec 2022, 01:10 张志豪, @.***> wrote:

[image: image] https://user-images.githubusercontent.com/12044174/206062943-adccb6a6-e3ac-4400-9c52-dc9569689bb5.png It actually works, I don't understand what exactly you requested.

— Reply to this email directly, view it on GitHub https://github.com/izhangzhihao/intellij-rainbow-brackets/issues/2567#issuecomment-1340237015, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4GOTVX2TRG6DH5NVLLZ7NLWL7PZHANCNFSM6AAAAAASVJDUXQ . You are receiving this because you were mentioned.Message ID: @.***>

--

This message (and any associated files) is intended only for the use of the individual or entity to which it is addressed and may contain information that is confidential, subject to copyright, or constitutes a trade secret. If you are not the intended recipient you are hereby notified that any dissemination, copying or distribution of this message, or files associated with this message, is strictly prohibited.

Internet communications cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. Therefore, we do not accept responsibility for any errors or omissions that are present in this message, or any attachment, that have arisen as a result of e-mail transmission. If verification is required, please request a hard-copy version. Any views or opinions presented are solely those of the author and do not necessarily represent those of the company.

ben-woodward-appsbroker avatar Dec 07 '22 09:12 ben-woodward-appsbroker

I do think it works as expected, right? image

izhangzhihao avatar Dec 07 '22 09:12 izhangzhihao

Not working for me sadly

[image: image.png]

On Wed, 7 Dec 2022 at 09:23, 张志豪 @.***> wrote:

I do think it works as expected, right? [image: image] https://user-images.githubusercontent.com/12044174/206139432-919d3824-657e-4f1a-b3a3-a478a2418544.png

— Reply to this email directly, view it on GitHub https://github.com/izhangzhihao/intellij-rainbow-brackets/issues/2567#issuecomment-1340639797, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4GOTVTZLVUZ7ZKYXE3K66LWMBJRZANCNFSM6AAAAAASVJDUXQ . You are receiving this because you were mentioned.Message ID: @.***>

--

This message (and any associated files) is intended only for the use of the individual or entity to which it is addressed and may contain information that is confidential, subject to copyright, or constitutes a trade secret. If you are not the intended recipient you are hereby notified that any dissemination, copying or distribution of this message, or files associated with this message, is strictly prohibited.

Internet communications cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. Therefore, we do not accept responsibility for any errors or omissions that are present in this message, or any attachment, that have arisen as a result of e-mail transmission. If verification is required, please request a hard-copy version. Any views or opinions presented are solely those of the author and do not necessarily represent those of the company.

ben-woodward-appsbroker avatar Dec 07 '22 09:12 ben-woodward-appsbroker

I could not see your img, can you upload it on GitHub?

izhangzhihao avatar Dec 07 '22 09:12 izhangzhihao

Apologies

image

ben-woodward-appsbroker avatar Dec 07 '22 09:12 ben-woodward-appsbroker

Can you post your env?

izhangzhihao avatar Dec 07 '22 09:12 izhangzhihao

And your setting page

izhangzhihao avatar Dec 07 '22 09:12 izhangzhihao

I don't know why, but you must update the latest version 2022.3.5. If the gray is still there, please re-open the issue.

izhangzhihao avatar Dec 07 '22 09:12 izhangzhihao

And maybe this issue is caused by other plugins that you installed and I don't know, please try changing the setting page and disabling other plugins.

izhangzhihao avatar Dec 07 '22 09:12 izhangzhihao

Env? I'm using Webstorm 2022.3

image

I don't have a great many non-standard plugins, I'll disable them

ben-woodward-appsbroker avatar Dec 07 '22 09:12 ben-woodward-appsbroker

Right, it's the one plugin I can't disable - Monokai Pro https://plugins.jetbrains.com/plugin/13643-monokai-pro-theme

I'll go over their side and see what can be looked at.

ben-woodward-appsbroker avatar Dec 07 '22 09:12 ben-woodward-appsbroker

Cool, I can repeat it in 2022.3 now.

izhangzhihao avatar Dec 07 '22 09:12 izhangzhihao

Looks to be theme related, I lose the colour when on the "Light" theme, but it's there on "Dark" and "High Contrast"

ben-woodward-appsbroker avatar Dec 07 '22 09:12 ben-woodward-appsbroker