compare-url icon indicating copy to clipboard operation
compare-url copied to clipboard

Published 20 hours ago • verified publisher icon iynere

feedback from angular folks

Open iynere opened this issue 6 years ago • 1 comments

https://github.com/angular/angular/commit/7374dfd1fa7a2c1a42ce8d4078fbe6d70a74fb89

iynere avatar Jan 28 '19 20:01 iynere

  1. (By looking at the code) it would only work if the rerun workflow is the latest workflow on the branch (which is not guaranteed to be true)
  2. It is less efficient (e.g. makes unnecessary CircleCI API requests for builds on different branches, installs extra dependencies, persists files to the workspace (as a means of passing the result to the calling job), etc.)
  3. It is slightly more complicated to setup and consume than our own script
  4. Its implementation is more complicated than needed for our usecase (e.g. handles different git providers, handles newly created branches, etc.)

iynere avatar Jan 28 '19 20:01 iynere