Anton Wiklund

Results 22 comments of Anton Wiklund

This PR is interesting! However, I'm curious about [this line](https://github.com/CommunitySolidServer/CommunitySolidServer/pull/1000/files#diff-d9b19d387e14fa5153782119331fffa6c93dafd5ad69e86573e9779e8c510e4cR44) Does this mean that there may only be a single `ldp:constrainedBy` predicate for a container? In some cases, I suppose...

In our case, it has certainly proven to be a pain point for new developers getting involved with this source code and its configurations. Using the "Search in all files"-feature...

> > Just FYI should you request a review soon: next week I'm on holidays. > > I am also not working next week and the week of august the...

Thanks @jaxoncreed for the comments! 👍

Thanks for the comments/questions @joachimvh Note that this PR is based upon an older version of the (evolving) notification & webhook spec. At the time this capability was needed by...

@BelgianNoise can you link the specs in the PR description? * [Solid Notifications](https://github.com/solid/notifications-panel/blob/3fdc8057d88d6c2e38055557fe62cc3f9c1ba752/proposals/solid-notifications.md#features) * [Solid Webhook Notifications](https://github.com/solid/notifications/blob/51bb5415a2be02a8cfab3b741b3a6a4297a51a79/webhook-subscription.md#10-webhook-request-with-token-signed-by-the-pod-key)

Right, at this point at least this version of the implementation(and older spec) fulfills our current needs as a client. For reworking this implementation to be up-to-date with the latest...

@BelgianNoise I was doing some further testing with this PR and I noticed that the `type` property is incorrectly set to `WebhookSubscription2021` but should instead be one of the ActivityStream...

> That is fine by me, but this won't start immediately though. I'm currently working on adding ACP to the server. Yes that's okay. For the time being will use...

One more thing can we also include the `topic` in the notification object? It was included in our initial implementation, but looks like it's missing in this version. So the...