sidekiq-throttled icon indicating copy to clipboard operation
sidekiq-throttled copied to clipboard

Fix Redis 4.6 deprecation warnings

Open dbackeus opened this issue 2 years ago • 4 comments

Also prepares the gem for compatibility with Redis 5

Example warning:

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

Note: The specs remains unchanged as the behaviour is already verified via https://github.com/sensortower/sidekiq-throttled/blob/master/spec/sidekiq/throttled/fetch_spec.rb#L62-L68

Closes #112

dbackeus avatar Apr 05 '22 09:04 dbackeus

Any updates with merging this?

legendetm avatar May 13 '22 08:05 legendetm

Thank you! Merged and released as 0.16.0.

ixti avatar Jun 13 '22 00:06 ixti

Thanks @ixti

BTW is https://github.com/ixti/sidekiq-throttled the new main repository for sidekiq-throttled? If so, would be helpful to archive this repo and change the README to link to the new repo.

dbackeus avatar Jun 13 '22 07:06 dbackeus

Thanks @ixti

BTW is https://github.com/ixti/sidekiq-throttled the new main repository for sidekiq-throttled? If so, would be helpful to archive this repo and change the README to link to the new repo.

Personally, I don't care where to keep development, but I've lost the access tot his repo... :D

ixti avatar Jun 13 '22 14:06 ixti