Alexey Zapparov
Alexey Zapparov
@tarcieri Yeah I know. Didn't found any good name - so decided that for sake of example it gives an overall idea. :D
After revisiting this thread - I changed my mind (partially) and think that `:host => ...` option looks better indeed, but I don't see it fitting future session object though....
I usually tend to do `client.close` on such errors. E.g. that's some sort of extraction from my "retriable client" (that I will open source as soon as it will stop...
Response keeps connection until response body is consumed. There are couple of ways to achieve this: ``` ruby # pretty much syntax sugar for `tap(&:to_s)`. response = HTTP.post(...).flush ``` or:...
I somewhat agree that documentation should be improved. But I disagree that default behaviour is bad. If you don't want connection to be open, close it implicitly (by consuming body...
Well, there's something wrong with this error in general :(( It's not related to message matching, this *sslv3 alert unsupported certificate* is causing other specs to fail too :((
I had no time to do a full review, but there's one thing that I would like to be changed. Default list of statuses to retry should be 5XX. So...
@Deepak275 Please update your code to run with latest stable http gem version. API of `#timeout()` was simplified in [4.0.0](https://github.com/httprb/http/blob/master/CHANGES.md#400-2018-10-15). For earlier versions you should use full-syntax, see: https://github.com/httprb/http/pull/446
I agree that we should not limit body to be rewindable. We just need to raise proper error if response body can't be rewinded upon re-usage attempt. About WebMock in...
Hm... But global timeout is doing a bit different thing, it's basically timeout for `connect + write + read`. IN other words it won't solve your problem if I understand...