Alexey Zapparov

Results 369 comments of Alexey Zapparov

FWIW, we can change `Body#each` to: ``` ruby module HTTP class Response class Body # ... # Iterate over the body, allowing it to be enumerable def each(buffer_size: Connection::BUFFER_SIZE while...

``` ruby HTTP.basic_auth(user: "3705c24ef1f98c13f78f893f7fb44962", pass: "e204c1206e7648dd2c129b303ce0d49a") ``` Generates same headers as: ``` ruby HTTP.headers("Authorization" => "Basic MzcwNWMyNGVmMWY5OGMxM2Y3OGY4OTNmN2ZiNDQ5NjI6ZTIwNGMxMjA2ZTc2NDhkZDJjMTI5YjMwM2NlMGQ0OWE=") ``` Thus, I'm a bit confused with what could be wrong. Can you...

One thing to keep in mind during the design (something that we overlooked in the current implementation) is that read timeout should correctly handle timeouts during both stages: * read...

I'm experiencing the same issue: ``` typescript const sourceFiles = command.local.runOutput({ dir: `${__dirname}/lambda`, command: "exit 0", assetPaths: ["**.go", "!**_test.go"] }); const bootstrap = new command.local.Command(name, { addPreviousOutputInEnv: false, create: "go...

> If passing Addressable::URI as a request pattern worked, it was only accidental, as this was never officially supported. The change introduced in [f651c25](https://github.com/bblimke/webmock/commit/f651c254a3a8d75ec3b2bef73bae35979c9ae5fc) was added as a safety check...

After giving it another thought, if that's expected behaviour (no accepting Addressable::URI for any reason in fact), then I'm cool with that. Simply thought it was a regression, as gem...

@postmodern @bblimke WDYT about: elsif uri.respond_to?(:to_str) URIStringPattern.new(uri) else That way it will support `Addressable::URI`, `String`, and anything that effectively representation of a String :D See: https://github.com/bblimke/webmock/pull/1073/commits/449c0a3d8551b5f3eb63357059f457bf27549bb6

@bblimke I've rebased PR on top of master. Are there any chances it can be landed?

@koic @bblimke is there any chance to get this merged?