bootstrap-touch-carousel icon indicating copy to clipboard operation
bootstrap-touch-carousel copied to clipboard

Do not hide captions on smaller screens

Open conoverm opened this issue 11 years ago • 5 comments

On the example page when viewed on an iPad 2, the content within each ".item" does not show.

(It does swipe, though.)

2013-10-16_17 19 15_p_ipad

conoverm avatar Oct 16 '13 21:10 conoverm

hey @conoverm, thanks for reporting!

I've conceal the whole captions for smaller screen, cause of the limited space on these devices.

// Hide/rearrange for smaller screens
@media screen and (max-width: 768px) {

  // Show and left align the captions
  .carousel-caption {
    display: none
  }
}

However, I could imagine to make this optional. So you can enable captions on smaller screen via data-attributes. would that be an option for you?

Cheers

ixisio avatar Oct 18 '13 07:10 ixisio

I've correct the media-query to exclude iPad portrait orientation (max-width:767px).

Have in mind to make this optional.

Cheers

ixisio avatar Oct 20 '13 11:10 ixisio

I decided to not include this feature. It feels a bit over-engineered, IMO.

ixisio avatar Jan 20 '14 17:01 ixisio

IMO, feels a little over-engineered to hide the captions in the first place. I think the styling details should be left to the implementer.

jtremback avatar Feb 13 '14 00:02 jtremback

hey @jtremback, Agreed! will put it into the next release..

ixisio avatar Feb 13 '14 08:02 ixisio