chinolor icon indicating copy to clipboard operation
chinolor copied to clipboard

Confusing syntax highlight: meta.function-call.arguments

Open shikibu-z opened this issue 2 years ago • 2 comments

First of all, thanks for creating and maintaining this theme. I really like this one and have been using it for years.

Problem:

The scope "meta.function-call.arguments" is highlighted similar to "meta.function-call" with color #8abcd1. This could be confusing to differentiate arguments (variables) from functions/methods.

Suggestion

Add "meta.function-call.arguments" to https://github.com/iwyvi/chinolor/blob/3681af1464cd3349d49b4eb18fe6cd28eb886ab6/themes/Chinolor-color-theme.json#L57

shikibu-z avatar Jul 18 '23 01:07 shikibu-z

Thank you for your suggestion.

Could you provide a code snippet example that includes meta.function-call.arguments and meta.function-call?

iwyvi avatar Jul 18 '23 02:07 iwyvi

I'm currently using something like

        {
            "name": "Variables",
            "scope": [
                "variable",
                "meta.function-call.arguments",
                "string constant.other.placeholder"
            ],
            "settings": {
                "foreground": "#e4dfd7"
            }
        },

by adding "meta.function-call.arguments" specifically to the "Variable" scope. The "meta.function-call" is left untouched as

        {
            "name": "Function, Special Method",
            "scope": [
                "entity.name.function",
                "entity.name.method",
                "meta.function-call",
                "variable.function",
                "support.function",
                "keyword.other.special-method"
            ],
            "settings": {
                "foreground": "#8abcd1"
            }
        },

This is tested to work properly in Python3.

shikibu-z avatar Jul 18 '23 16:07 shikibu-z