iwubcode

I left some comments on general code optimization / structure. I admittedly haven't fully absorbed everything here yet. There were a few places where we were doing something like: ```...

@Pokechu22 - if you have time, would you mind reviewing this? My only concern was destination alpha but I tested that on another game just now and it seems to...

@Pokechu22 - tested smg2 shadows. There was a code change needed as when `destAlpha` is set, the values are swapped, without it...the shadow never change intensity. After the change, seems...

@Pokechu22 - thanks for your comment and for spending your time on this. After you commented, I added support to my editor to toggle all mods on/off and noticed that...

> I don't think that's going to work super well. In most cases blending doesn't happen in the shaders in dolphin Not sure why not. As for frame buffer fetch,...

Thank you both for your comments. ~~As mentioned on Discord, I think the current code seems to merge blending and non-blending in a way that makes it hard to do...

After discussing more with Tellow, I realized I was going about it all wrong and that's why everything was complicated. I think Pokechu hinted at it earlier as well but...

I am not as passionate as either of you about color output, HDR, or gamma. Regardless, I will give some general thoughts /opinions. Maybe @Filoppi can remind me, why is...

> I would appreciate smooth review. Last time you were requesting changes for one month and in the end you told me you do not want to merge it. First...

I don't own this game so I can't check this particular effect (would be nice to have a fifolog?) but my hope is that #12156 will resolve these sorts of...