internetcards icon indicating copy to clipboard operation
internetcards copied to clipboard

New Feature: Waiting Lobby

Open arif599 opened this issue 4 years ago • 3 comments

First of I wanted to say I really enjoyed this project. By the way, I'm learning GitHub and also new to Python, I would like to give my insights on this new feature and possibly contribute later on.

Waiting lobby: There should be a lobby where a user can enter and see how many players are online and waiting for a partner/group. Kind of like the lobby in among us. I think this will be a great enhancement for this project.

image

arif599 avatar Oct 22 '20 20:10 arif599

This is a neat feature that I hadn't thought of before. However, it does seem mildly difficult due to how game state is presently stored (it is stored as a dictionary). However, I will certainly consider it.

As some notes for you, me, and anyone else who may want to contribute to this issue (in no particular order):

  • This will probably require adding a public_games list that consists of game IDs (from games) and (possibly) an associated name to publicly identify it.
  • This will require a new join flow for users joining public games (probably: click "Join public room" -> click room -> enter username -> enter game lobby).
  • The ability to create a public game should probably be displayed as a checkbox on the "Make Room" screen, that when checked reveals an (optional?) name field for the game.

iwotastic avatar Oct 22 '20 21:10 iwotastic

I'm reopening this issue because I want to remind myself that it exists. I have been busy with college applications and such, so I haven't had time to work on this. Once the hectic college application rush calms down, I will attempt to make progress on this. Until then, anyone is welcome to pick up where I left off on 6be2c514c6427f4250de5a068232950b04f6dc34.

iwotastic avatar Nov 22 '20 21:11 iwotastic

Alright sounds good, I didn't want this issue to keep lingering in your repository so I figured it would be better if I close it. But I feel you, I just finished my college apps. Good luck on your applications!

arif599 avatar Nov 22 '20 21:11 arif599