slab-tree icon indicating copy to clipboard operation
slab-tree copied to clipboard

Fixed a bug in set_root.

Open jsinger67 opened this issue 4 years ago • 4 comments

Hi Ian, I found a bug in set_root that introduced some inconsistency later when adding children to the new root. My code contains a test too. If you temporarily comment out my change in tree.rs the test will fail.

If you have any questions, let me know.

Have fun Jörg

jsinger67 avatar Nov 29 '20 16:11 jsinger67

I ran into this when calling make_last_sibling on a child of the new root, and found that tree traversal was broken. Your branch fixes the problem. Currently I'm using it like this:

[dependencies.slab_tree]
version = "0.3.2"

[patch.crates-io.slab_tree]
git = "https://github.com/jsinger67/slab-tree.git"
branch = "set_root_fix"

Any chance this can be pulled in?

chylex avatar May 15 '23 21:05 chylex

This bug was the reason why I refrained from using this crate in my project. I think there is no maintenance anymore for this crate which is actually really sad. Maybe someone should maintain a fork of it.

jsinger67 avatar May 16 '23 08:05 jsinger67

Hi. I have interest in adopting this crate. I forked it on: https://github.com/osimarr/slab-tree I applied the fix from @jsinger67 and added some new changes.

osimarr avatar Mar 27 '24 03:03 osimarr

Great news. Thanks for your obligation. It would otherwise be sad if this very potential crate drops off. So I appreciate your willingness and will surely support you.

jsinger67 avatar Mar 27 '24 06:03 jsinger67